Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workdir setting #2283

Merged
merged 5 commits into from
Jul 31, 2024
Merged

Add workdir setting #2283

merged 5 commits into from
Jul 31, 2024

Conversation

nyurik
Copy link
Contributor

@nyurik nyurik commented Jul 29, 2024

Implement #2273 - an ability to set workdir for the entire justfile

@casey
Copy link
Owner

casey commented Jul 29, 2024

Nice! Check out Recipe::working_directory. If self.change_directory() is true, first use the workdir setting, and if it isn't present, Use the existing logic.

@nyurik nyurik force-pushed the workdir branch 2 times, most recently from 5069040 to 8aad8a2 Compare July 29, 2024 16:00
@nyurik
Copy link
Contributor Author

nyurik commented Jul 29, 2024

thx @casey, seems to work, ready for review

@nyurik nyurik marked this pull request as ready for review July 29, 2024 16:01
@casey
Copy link
Owner

casey commented Jul 31, 2024

Nice! I did some refactoring, and renamed the setting working-directory for clarity, since i try to avoid too many abbreviations. We could eventually also allow working-dir as an alias.

This also made me realize that there's a bug! backticks do not execute in the correct directory if they're in a submodule. I'll fix that in another PR.

@casey casey enabled auto-merge (squash) July 31, 2024 00:49
@casey casey merged commit 23a53fb into casey:master Jul 31, 2024
5 checks passed
@nyurik nyurik deleted the workdir branch July 31, 2024 00:56
@nyurik
Copy link
Contributor Author

nyurik commented Jul 31, 2024

thx! Are you sure you want a long working-dir when you already have a short tempdir ?

@casey
Copy link
Owner

casey commented Jul 31, 2024

I think so, just because I commonly hear tempdir, but people usually say working directory or working dir, and workdir feels a little less common.

@nyurik
Copy link
Contributor Author

nyurik commented Jul 31, 2024

🤷 your call. I searched github for code matches:

P.S. working directory mostly seem to show up in documentation, but workdir tend to be a lot in the actual code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants