Skip to content
This repository has been archived by the owner on Oct 17, 2023. It is now read-only.

Support Gradle incremental annotation processing #95

Closed
gildor opened this issue May 14, 2019 · 8 comments
Closed

Support Gradle incremental annotation processing #95

gildor opened this issue May 14, 2019 · 8 comments

Comments

@gildor
Copy link

gildor commented May 14, 2019

AssistedInject should support Gradle incremental AP: https://docs.gradle.org/nightly/userguide/java_plugin.html#sec:incremental_annotation_processing

All AP that we use in our project already supports incremental AP except AssistedInject so it's impossible to have incremental AP until all AP in your project support it

@JakeWharton
Copy link
Contributor

JakeWharton commented May 14, 2019 via email

@gildor
Copy link
Author

gildor commented Jul 30, 2019

Fixed in #100

@himattm
Copy link

himattm commented Jul 30, 2019

Are there any updates on when this will be released? Very much looking forward to having this.

@JakeWharton
Copy link
Contributor

Can you test it with the snapshot? Hearing that it works in the real-world would give confidence on shipping it.

@gildor
Copy link
Author

gildor commented Jul 31, 2019

@JakeWharton I'm using now snapshot version, everything looks fine, but it's quite tricky to test manually, probably we need some integration test for this to be sure

@himattm
Copy link

himattm commented Aug 2, 2019

@JakeWharton I've tested as well. I ran ./gradlew aDeb -Pkapt.verbose=true with one dependency that I knew would fail and found that it is no longer included in the list of unsupported processors.

[INFO] Incremental KAPT support is disabled. Processors that are not incremental: android.arch.lifecycle.LifecycleProcessor.

@JakeWharton
Copy link
Contributor

JakeWharton commented Aug 2, 2019 via email

@JakeWharton
Copy link
Contributor

Released as 0.5.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants