This repository has been archived by the owner on Oct 17, 2023. It is now read-only.
Add incremental annotation processing support to assisted inject. #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oldergod
reviewed
Jul 4, 2019
runningcode
force-pushed
the
no/incremental-annotation-processing
branch
from
96e8e72
to
58191a7
Compare
|
Done! |
JakeWharton
reviewed
Jul 5, 2019
...ct-processor/src/main/java/com/squareup/inject/assisted/processor/AssistedInjectProcessor.kt
Outdated
Show resolved
Hide resolved
|
I did aggregating because there are multiple originating elements. The
multiple elements in different are combined to create the assisted module.
Is that correct?
Le ven. 5 juil. 2019 à 23:37, Jake Wharton <notifications@github.com> a
écrit :
… ***@***.**** commented on this pull request.
------------------------------
In
assisted-inject-processor/src/main/java/com/squareup/inject/assisted/processor/AssistedInjectProcessor.kt
<#100 (comment)>:
> @@ -50,6 +52,7 @@ import javax.lang.model.util.Types
import javax.tools.Diagnostic.Kind.ERROR
import javax.tools.Diagnostic.Kind.WARNING
***@***.***(AGGREGATING)
Why is this aggregating? We generate one type per annotated class.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#100>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACRGNLA4QQROQ7NZSMHPITP565KVANCNFSM4H5XN4FA>
.
|
|
That's for the Dagger 2 processor. I was asking about the factory processor. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.