Add reproduction logs #1732
Merged
Add reproduction logs #1732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@golnooshasefi please update to resolve conflicts?
Thanks for noting. This might be a Windows issue...? |
|
Resolved the conflicts.
It may be. I'm guessing it's because of the difference in the line break types. |
lintool
reviewed
Nov 30, 2023
lintool
reviewed
Nov 30, 2023
lintool
reviewed
Nov 30, 2023
| @@ -337,4 +337,5 @@ Before you move on, however, add an entry in the "Reproduction Log" at the botto | |||
| + Results reproduced by [@Seun-Ajayi](https://github.com/Seun-Ajayi) on 2023-11-13 (commit [`086e16b`](https://github.com/castorini/pyserini/commit/086e16be28b7dc6022f8582dbd803824dc2c1ad2)) | |||
| + Results reproduced by [@AndreSlavescu](https://github.com/AndreSlavescu) on 2023-11-28 (commit [`1219cdb`](https://github.com/castorini/pyserini/commit/1219cdbca780e869ba77658c29e1aaa972585d09)) | |||
| + Results reproduced by [@tudou0002](https://github.com/tudou0002) on 2023-11-28 (commit [`723e06c`](https://github.com/castorini/pyserini/commit/723e06c3b04e6c6fcd56fcf5bce4386c72503e5a)) | |||
| + Results reproduced by [@golnooshasefi](https://github.com/golnooshasefi) on 2023-11-28 (commit [`1219cdb`](https://github.com/castorini/pyserini/commit/1219cdbca780e869ba77658c29e1aaa972585d09)) | |||
There was a problem hiding this comment.
move down to final entry to be consistent.
There was a problem hiding this comment.
The results were reproduced on the 28th of November, which is why it's placed before the final entry.
golnooshasefi
force-pushed
the
golnoosh-asefi
branch
from
89f0b9b
to
069e5d9
Compare
lintool
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything worked accordingly.
Operating System:
Development Environment:
Hardware:
One more thing, there was this discrepancy with the output of this command in
experiments-msmarco-passage.md, where the number of the lines and the characters were the same, but the number of the words were one less than the output mentioned in the file: