-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add query iterator #309
add query iterator #309
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you kill the --ordered
option? I can't think of a reason why you wouldn't want ordered?
But otherwise, 🚢 it!
Hrm, conflicts need to be resolved. After this gets merged we need to re-do replication numbers. Actually @MXueguang - one more thing, please document in query_iterator why we actually need to do this - a reference to the GitHub issue should do. Happy to review it again if you want, but otherwise just merge please. |
We'll also need to rerun multi-threaded search and make sure there are no weird interactions. |
updated scores in multithreading gives same results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
in current version, we added a flag
--ordered
to the pypi replication to use the query order array.