Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaned up path appends to current directory #988

Merged
merged 2 commits into from
Feb 6, 2022
Merged

Cleaned up path appends to current directory #988

merged 2 commits into from
Feb 6, 2022

Conversation

HAKSOAT
Copy link
Contributor

@HAKSOAT HAKSOAT commented Feb 6, 2022

This pull request addresses #917

@HAKSOAT
Copy link
Contributor Author

HAKSOAT commented Feb 6, 2022

@lintool I worked on the cleanups. However, I noticed this line. I didn't clean that up because of the comment right above it. Should I leave it?

@lintool
Copy link
Member

lintool commented Feb 6, 2022

@lintool I worked on the cleanups. However, I noticed this line. I didn't clean that up because of the comment right above it. Should I leave it?

No, I think we should remove this one also... thanks!

@HAKSOAT
Copy link
Contributor Author

HAKSOAT commented Feb 6, 2022

Great. I've removed that as well.

@lintool lintool merged commit e03e068 into castorini:master Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lintool lintool lintool approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HAKSOAT @lintool