Add passing list of results as option to analyser class #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sahel-sh
requested changes
Feb 3, 2024
AndreSlavescu
force-pushed
the
refactor
branch
from
a2ebb30
to
9e1d990
Compare
sahel-sh
requested changes
Feb 4, 2024
| """ | ||
| num_passages = [] | ||
| responses = [] | ||
| for result in self._data: |
There was a problem hiding this comment.
in the saved responses mode, the execution summary is stored using the function in https://github.com/castorini/rank_llm/blob/main/src/rank_llm/result.py#L38
It is decoupled from the result. That's why the for loop is implemented the way it is in lines 24-30
AndreSlavescu
force-pushed
the
refactor
branch
from
6355fbe
to
0c49504
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #77