Formatting message handles empty files.

castwide · Mar 26, 2020 · ec8b181 · ec8b181
1 parent c020026
commit ec8b181
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 11 deletions.
diff --git a/lib/solargraph/language_server/message/text_document/formatting.rb b/lib/solargraph/language_server/message/text_document/formatting.rb
@@ -36,17 +36,22 @@ def process
           # @param result [String]
           # @return [void]
           def format original, result
-            if original.end_with?("\n")
-              ending = {
-                line: original.lines.length,
-                character: 0
-              }
-            else
-              ending = {
-                line: original.lines.length - 1,
-                character: original.lines.last.length
-              }
-            end
+            ending = if original.end_with?("\n")
+                       {
+                         line: original.lines.length,
+                         character: 0
+                       }
+                     elsif original.lines.empty?
+                       {
+                         line: 0,
+                         character: 0
+                       }
+                     else
+                       {
+                         line: original.lines.length - 1,
+                         character: original.lines.last.length
+                       }
+                     end
             set_result(
               [
                 {

diff --git a/spec/language_server/message/text_document/formatting_spec.rb b/spec/language_server/message/text_document/formatting_spec.rb
@@ -0,0 +1,15 @@
+describe Solargraph::LanguageServer::Message::TextDocument::Formatting do
+  it 'gracefully handles empty files' do
+    host = double(:Host, read_text: '')
+    request = {
+      'params' => {
+          'textDocument' => {
+          'uri' => 'test.rb'
+        }
+      }
+    }
+    message = Solargraph::LanguageServer::Message::TextDocument::Formatting.new(host, request)
+    message.process
+    expect(message.process.first[:newText]).to be_empty
+  end
+end