Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep generated headers within project binary directory #2604

Merged
merged 1 commit into from
Dec 28, 2022
Merged

Keep generated headers within project binary directory #2604

merged 1 commit into from
Dec 28, 2022

Conversation

ChrisThrasher
Copy link
Collaborator

Description

This stops the generated-includes/ directory from appearing in the build directories of projects that consume Catch2 via add_subdirectory.

This stops them from appearing in the build directories of projects
that may consume Catch2.
@codecov
Copy link

codecov bot commented Dec 27, 2022

Codecov Report

Merging #2604 (1be954f) into devel (78bb4fd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            devel    #2604   +/-   ##
=======================================
  Coverage   91.13%   91.13%           
=======================================
  Files         187      187           
  Lines        7634     7634           
=======================================
  Hits         6957     6957           
  Misses        677      677           

@horenmar
Copy link
Member

Sure, that makes sense.

@horenmar horenmar added the Building and Packaging Issues affecting build/packaging scripts and utilities label Dec 28, 2022
@horenmar horenmar merged commit 0c62167 into catchorg:devel Dec 28, 2022
@ChrisThrasher ChrisThrasher deleted the generated_includes_directory branch December 28, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Building and Packaging Issues affecting build/packaging scripts and utilities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants