feat(signup): add multi-page signup to our flow #1824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use these things. While PHP doesn't give me Array<Type>, it at least lets me get some help from a text editor around some of this stuff. Also, this way I can avoid doing the math in the handler for my display text. I'd rather define a lot of this stuff (see: the annual savings amount) on the backend, but we have what we have available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With an upcoming change in our authentication (using CP's oauth system instead of the saml system we use now), we're going to need to change how we handle signing up for an account.
This is a multi-step system that allows our users to sign up and be immediately logged in.
A huge thing here is that there is a new pattern for handling a routed to PHP file:
The Handler!
Handlers allow me to mock the instance of the
RequestContextobject, which means we can write unit tests for how we handle form submissions, munge data, where we make calls to, etc. We also have the beginnings of a Validator in here, something where we can check the bodies of POSTs.I'm definitely up for a discussion on a lib I could use instead of building our own, but I basically am using one already.