Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADR 4: Migrate to Laravel #2280

Merged
merged 4 commits into from
Aug 18, 2022
Merged

ADR 4: Migrate to Laravel #2280

merged 4 commits into from
Aug 18, 2022

Conversation

stoyan
Copy link
Contributor

@stoyan stoyan commented Aug 17, 2022

No description provided.

jefflembeck
jefflembeck approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@jefflembeck jefflembeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the typo nitpick, this seems like a great approach. Dumping routing from nginx.conf so we can have a single point of entry will certainly be some lifting, but feels like a totally doable first big move.

stoyan and others added 2 commits August 18, 2022 12:21
@stoyan @jefflembeck
Update docs/adr/0004-adopt-laravel.md
0d0cfbf 
Co-authored-by: Jeff Lembeck <jlembeck@gmail.com>
formatting lists
c49d095
@stoyan stoyan merged commit 0e6ba76 into master Aug 18, 2022
@stoyan stoyan deleted the adr4 branch August 18, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefflembeck jefflembeck jefflembeck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stoyan @jefflembeck