-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pythonanywhere): init #1243
Conversation
Co-authored-by: uncenter <47499684+uncenter@users.noreply.github.com>
I might pick this up and finish it |
Feel free to. You should be able to just push to this branch I think? Lmk. |
Co-authored-by: uncenter <47499684+uncenter@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's a few classes from ace editor that are unthemed however I think it's fine for now until ace editor is like it's own thing, other than that I think everything else is good
What classes are unthemed for Ace? Do you mind theming them before we merge this? |
Cool, I'm all set with this. Any last concerns @isabelroses @trinkey? (I can't approve my own PR.) |
lgtm (i would review but i cant find the button in github mobile app) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, huge userstyle. Good luck maintainaing it.
(For the record go to Files Changed for the PR (the diff) and then the Finish Review button should be at the bottom of the screen and you can approve through there.) |
Just leaving this here if anyone wants to pickup (I might again at some point). Follows #1217, which was based upon #776. Did some fixes myself originally for #1217 but seeing as that is closed... didn't want my time to go to waste.