Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pythonanywhere): init #1243

Merged
merged 51 commits into from
Nov 12, 2024
Merged

feat(pythonanywhere): init #1243

merged 51 commits into from
Nov 12, 2024

Conversation

uncenter
Copy link
Member

Just leaving this here if anyone wants to pickup (I might again at some point). Follows #1217, which was based upon #776. Did some fixes myself originally for #1217 but seeing as that is closed... didn't want my time to go to waste.

somerand0mcat and others added 28 commits August 20, 2024 18:42
Co-authored-by: uncenter <47499684+uncenter@users.noreply.github.com>
@trinkey
Copy link
Contributor

trinkey commented Oct 27, 2024

I might pick this up and finish it

@uncenter
Copy link
Member Author

Feel free to. You should be able to just push to this branch I think? Lmk.

@uncenter uncenter requested a review from trinkey November 11, 2024 20:48
trinkey
trinkey previously approved these changes Nov 11, 2024
Copy link
Contributor

@trinkey trinkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a few classes from ace editor that are unthemed however I think it's fine for now until ace editor is like it's own thing, other than that I think everything else is good

@uncenter
Copy link
Member Author

What classes are unthemed for Ace? Do you mind theming them before we merge this?

styles/pythonanywhere/catppuccin.user.css Outdated Show resolved Hide resolved
styles/pythonanywhere/catppuccin.user.css Outdated Show resolved Hide resolved
styles/pythonanywhere/catppuccin.user.css Outdated Show resolved Hide resolved
@uncenter
Copy link
Member Author

Cool, I'm all set with this. Any last concerns @isabelroses @trinkey? (I can't approve my own PR.)

@trinkey trinkey requested review from trinkey and removed request for isabelroses November 12, 2024 19:16
@trinkey
Copy link
Contributor

trinkey commented Nov 12, 2024

lgtm (i would review but i cant find the button in github mobile app)

Copy link
Member

@isabelroses isabelroses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, huge userstyle. Good luck maintainaing it.

@uncenter uncenter requested review from a team and removed request for trinkey November 12, 2024 19:20
@uncenter
Copy link
Member Author

(i would review but i cant find the button in github mobile app)

(For the record go to Files Changed for the PR (the diff) and then the Finish Review button should be at the bottom of the screen and you can approve through there.)

@uncenter uncenter merged commit 8d48f59 into main Nov 12, 2024
3 checks passed
@uncenter uncenter deleted the feat/pythonanywhere branch November 12, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants