-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nixos-manual): init #1443
feat(nixos-manual): init #1443
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated hr elements and highlight.js styling + preview image. |
Hey @uncenter, just wanted to check if there was anything else needed regarding this PR. :) |
Nothing needed from your end at the moment, we have a bit of a backlog of init PRs that I need to review first. Hopefully I can do a more thorough review later this week, luckily this userstyle is relatively small so it won't take very long. |
I'm noticing quite a lot of linter errors. Some of them should be fixable with |
Co-authored-by: uncenter <47499684+uncenter@users.noreply.github.com>
Thanks @isabelroses, the linter was unfortunately not able to fix them itself, instead I did so manually. The following two errors might be possible to mitigate (to some degree) in the future is the following:
In the template both of these use the |
Thanks for your feedback. ❤️ |
added category: wiki Co-authored-by: uncenter <47499684+uncenter@users.noreply.github.com>
changed hr and table of content bottom border color to overlay1 Co-authored-by: uncenter <47499684+uncenter@users.noreply.github.com>
Co-authored-by: uncenter <47499684+uncenter@users.noreply.github.com>
Co-authored-by: uncenter <47499684+uncenter@users.noreply.github.com>
removed darken Co-authored-by: uncenter <47499684+uncenter@users.noreply.github.com>
blue and green respectively
yellow and orange respectively
remove darken Co-authored-by: uncenter <47499684+uncenter@users.noreply.github.com>
Thanks for the review @uncenter, everything should now be corrected including the preview image. |
You can also add this snippet to theme examples https://nixos.org/manual/nixpkgs/stable/#sec-pkgs-fetchers-fetchzip-examples: div.example details[open] {
border-color: @surface1 !important;
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Isabel <isabel@isabelroses.com>
Co-authored-by: Isabel <isabel@isabelroses.com>
This comment was marked as outdated.
This comment was marked as outdated.
Looks nice! However in userstyles we try to avoid changing the layout, padding, etc - anything that isn't color related. Feel free to use that part of the snippet as a separate userstyle on your own, or you could even contribute that CSS to the manual generator upstream. |
Alright, make sense. |
Co-authored-by: uncenter <47499684+uncenter@users.noreply.github.com>
Co-authored-by: uncenter <47499684+uncenter@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on the PR. ❤️
Shortly after this is merged you will be invited to the userstyles maintainers team, This will allow you the ability to merge PRs for your userstyle.
Awesome and thank you. |
🎉 Theme for NixOS Manual (NixOS and nixpkgs) 🎉
NixOS Manual is the full documentation for both NixOS and nixpkgs.
💬 Additional Comments 💬
It was pretty straight forward to get most of the styling in place, some elements were a bit more stubborn but this was mainly with highlightjs.
The preview screenshot is of the main page without the table of contents (since that takes up about 2 pages, not very interesting).
All links are dictated by the users accent color.
🗒 Checklist 🗒
/styles/<name-of-website>
containing the contents of the/template
directory.userstyles.yml
file with information about the new userstyle.
catppuccin.user.css
- all the CSS for the userstyle, based on thetemplate.
preview.webp
- composite image of all four individual flavor screenshots (taken with the default accent color of mauve) stitched together, generated via Catwalk.