Store the container name of cloud in UFile domain #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivamkrpandey
commented
Jan 28, 2019
| } | ||
|
|
||
| String getContainer() { | ||
| containerName(Holders.flatConfig["fileuploader.groups.${fileGroup}.container"]) |
There was a problem hiding this comment.
Need to change the method name to fix the codeclimate issue of Code readability confusion as fieldName containerName is a good fit here.
devpriyanshu96
suggested changes
Jan 28, 2019
grails-app/services/com/causecode/fileuploader/FileUploaderService.groovy
Outdated
Show resolved
Hide resolved
| dateCreated bindable: false | ||
| lastUpdated bindable: false | ||
| envName bindable: false | ||
| containerName nullable: true |
There was a problem hiding this comment.
should we also add min-length validations to it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution / Approach
containerNamein the UFile domain.Test Procedures
containerName.