Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get the checksum file from archive.apache.org #119

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jcoyne
Copy link
Collaborator

@jcoyne jcoyne commented Jul 25, 2018

Previously, when a mirror was set it was trying to get the checksum from
www.us.apache.org which only had the checksums for the three supported
versions.

Previously, when a mirror was set it was trying to get the checksum from
www.us.apache.org which only had the checksums for the three supported
versions.
jcoyne added a commit to sul-dlss/argo that referenced this pull request Jul 25, 2018
www.us.apache.org only hosts the last point release for the last three
minor releases.

See cbeer/solr_wrapper#119
@jrochkind
Copy link
Contributor

jrochkind commented Sep 6, 2018

We just ran into this and spent some time debugging it ourselves before realizing there was already a PR here with a fix.

@cbeer is there any chance of getting this merged and included in a bugfix release? Is there anyone but @cbeer who can do that on this project?

@jrochkind
Copy link
Contributor

@jcoyne Does this actually address the same thing as #114 , that's been there since January?

@dkinzer
Copy link

dkinzer commented Oct 15, 2018

I think there might be something else going on with the checksum code. We tried overriding the checksum path url and it still failed even though sha1s were the same. The only workaround for us seems to be to ignore checksum altogether: tulibraries/tul_cob#755

@jrochkind
Copy link
Contributor

I'm confused about the difference between ignore_checksum: true that @dkinzer is using, and valid: false that we are to do the same thing. Maybe because @dkinzer is also passing a checksum: value (then telling solr_wrapper to ignore it?) and we aren't (so need to tell solr_wrapper not to try to fetch it?)?

Regardless, I'd really like if this problem was actually fixed in a solr_wrapper release, so we didn't all have to find confusing workarounds.

@cbeer is there any chance of a review/merge/release? Pretty please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants