Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if Python 3.12 works #192

Merged
merged 4 commits into from
Oct 9, 2023
Merged

Check if Python 3.12 works #192

merged 4 commits into from
Oct 9, 2023

Conversation

cbrnr
Copy link
Owner

@cbrnr cbrnr commented Sep 25, 2023

I don't expect it to work, but let's see.

@cbrnr
Copy link
Owner Author

cbrnr commented Sep 25, 2023

It's not working due to Numba. Maybe we should not test against our optional dependencies? Numba and Tensorflow are usually slow to support the latest Python versions (for understandable reasons).

@cbrnr
Copy link
Owner Author

cbrnr commented Sep 25, 2023

@hofaflo what do you prefer?

  1. Don't test on 3.12, but include Numba in our tests.
  2. Test on 3.12, and remove Numba from our tests.

If we don't change anything, we're in option 1. I tend to prefer option 2 though, because Numba is only an optional dependency, and I'd like to support Python 3.12 (and any future releases) ASAP. In addition, we are also not testing Tensorflow functionality (also an optional dependency), which would also delay our support for latest Python releases, so we're already inconsistent in testing/not testing optional deps.

@hofaflo
Copy link
Collaborator

hofaflo commented Sep 25, 2023

I would like to keep the Numba test to make sure nothing breaks there, but skip it for now, like we did last year (see #124)

@cbrnr
Copy link
Owner Author

cbrnr commented Sep 25, 2023

Ah, that's of course option 3, which I completely forgot to think of, and this is definitely the best option! Thanks!

@cbrnr
Copy link
Owner Author

cbrnr commented Sep 26, 2023

It looks like we will have to wait until Python 3.12 is released, unless we want to enable pre-release dependencies (e.g. cffi). I say we just wait.

@cbrnr cbrnr marked this pull request as draft September 26, 2023 06:49
@cbrnr
Copy link
Owner Author

cbrnr commented Oct 4, 2023

Seems like we need to wait for dateutil/dateutil#1284 (they have already fixed it, but have not cut a new release yet). Or we just silence this warning for now and hopefully not forget about it.

@cbrnr cbrnr marked this pull request as ready for review October 9, 2023 13:27
@cbrnr cbrnr merged commit 84143b7 into main Oct 9, 2023
5 checks passed
@cbrnr cbrnr deleted the py312 branch October 9, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants