-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if Python 3.12 works #192
Conversation
It's not working due to Numba. Maybe we should not test against our optional dependencies? Numba and Tensorflow are usually slow to support the latest Python versions (for understandable reasons). |
@hofaflo what do you prefer?
If we don't change anything, we're in option 1. I tend to prefer option 2 though, because Numba is only an optional dependency, and I'd like to support Python 3.12 (and any future releases) ASAP. In addition, we are also not testing Tensorflow functionality (also an optional dependency), which would also delay our support for latest Python releases, so we're already inconsistent in testing/not testing optional deps. |
I would like to keep the Numba test to make sure nothing breaks there, but skip it for now, like we did last year (see #124) |
Ah, that's of course option 3, which I completely forgot to think of, and this is definitely the best option! Thanks! |
It looks like we will have to wait until Python 3.12 is released, unless we want to enable pre-release dependencies (e.g. |
Seems like we need to wait for dateutil/dateutil#1284 (they have already fixed it, but have not cut a new release yet). Or we just silence this warning for now and hopefully not forget about it. |
I don't expect it to work, but let's see.