Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relative wallpaper background version selector (feature) #468

Closed
gfody opened this issue Mar 7, 2018 · 10 comments
Closed

relative wallpaper background version selector (feature) #468

gfody opened this issue Mar 7, 2018 · 10 comments
Assignees
Milestone

Comments

@gfody
Copy link

gfody commented Mar 7, 2018

I like to use my wallpaper as console background image, and I like to use slideshow for my wallpaper. Not every wallpaper is an appropriate background for text though and so the tint color option is handy, but a lot of my wallpapers have nighttime versions and it looks really cool to use those instead of tinting. Here's a couple of examples:

cap

cap2

..and so I'm thinking a feature where ConsoleZ can select the background version for the current wallpaper. It could be as simple as allowing a placeholder like %currentwallpaper% in the background image path or some simple pattern for specifying the folder naming convention.

@cbucher
Copy link
Owner

cbucher commented Mar 9, 2018

Sorry, but I don't understand what you mean by "background version for the current wallpaper".

@gfody
Copy link
Author

gfody commented Mar 9, 2018

I have pairs of wallpaper like somewallpaper.jpg + somewallpaper_nighttime.jpg, and when somewallpaper.jpg is my background I'd like to use somewallpaper_nighttime.jpg as my console background. I can configure this manually (as in the screenshots) but then when my wallpaper changes to the next image in the slideshow I have to manually change my console background again.

To get it working I would just support a simple placeholder in the background image path, reevaluate it when the wallpaper changes, and fallback on the current wallpaper when the files not found.

@cbucher
Copy link
Owner

cbucher commented Mar 16, 2018

Please, try last experimental version.

I modify the code to allow overriding of desktop wallpaper.
If a wallpaper picture is c\dir1\dir2\dir3\photo.jpg, we scan if this pictures exist (in this order):
c\dir1\dir2\dir3.ConsoleZ\photo.jpg
c\dir1\dir2.ConsoleZ\dir3\photo.jpg
c\dir1.ConsoleZ\dir2\dir3\photo.jpg

@cbucher cbucher self-assigned this Mar 16, 2018
@gfody
Copy link
Author

gfody commented Mar 17, 2018

perfect! I tested it out and it works, unfortunately for some reason the experimental build breaks the 'Next desktop background' action from the desktop context menu. As long as ConsoleZ is running clicking 'Next desktop background' does nothing, but if I close ConsoleZ it works again. Same is true for the current head 3e73473.

@gfody
Copy link
Author

gfody commented Mar 17, 2018

I tested each commit since the last stable release and 'Next desktop background' stops working in a913d7b.

@gfody
Copy link
Author

gfody commented Mar 18, 2018

99d317e fixed it!

@cbucher
Copy link
Owner

cbucher commented Mar 18, 2018

Gdi+ was locking pictures. I wrote a workaround.
Please, try last experimental version.

@gfody
Copy link
Author

gfody commented Mar 20, 2018

works well thanks!

@cbucher cbucher added this to the 1.18.3 milestone Apr 21, 2018
@cbucher cbucher closed this as completed Apr 21, 2018
@ericblade
Copy link

hey @gfody , as an aside, would you mind stating where these images you're using might be available? :-)

@gfody
Copy link
Author

gfody commented Apr 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants