Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI and build issues #20

Merged
merged 5 commits into from
Oct 27, 2023
Merged

Fix CI and build issues #20

merged 5 commits into from
Oct 27, 2023

Conversation

dfsnow
Copy link
Member

@dfsnow dfsnow commented Oct 26, 2023

This PR fixes build and CI issues uncovered by #19. Mainly it:

  • Fixes a path issue on Windows builds, example run here.
  • Adds a strange/suddenly missing dependency (prettymapr) to the DESCRIPTION file
  • Updates the Action versions where appropriate

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #20 (6378b16) into master (3d0349a) will not change coverage.
The diff coverage is n/a.

❗ Current head 6378b16 differs from pull request most recent head 43f58eb. Consider uploading reports for the commit 43f58eb to get more accurate results

@@            Coverage Diff            @@
##            master       #20   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          439       439           
=========================================
  Hits           439       439           

@dfsnow dfsnow force-pushed the fix-ci-dependencies-and-builds branch from 6a43639 to ff10575 Compare October 26, 2023 19:35
@dfsnow dfsnow merged commit 5c8435f into master Oct 27, 2023
10 checks passed
@dfsnow dfsnow deleted the fix-ci-dependencies-and-builds branch October 27, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants