Error message out of order?

[hadley]

pandoc::pandoc_convert("20230428 Brians Story v3.docx", from = "word", to = "markdown")
#> Unknown input format word
#> Error in `pandoc_run()`:
#> ! Running Pandoc failed with following error
#> Run `rlang::last_trace()` to see where the error occurred.

It took me a minute to figure out the error because it's preceding, not following.

[cderv]

Thanks. I need to review my usage of rlang::abort() then 🤔

pandoc/R/pandoc-run.R

Lines 24 to 28 in ee86163

	res <- suppressWarnings(system2(bin, args, stdout = TRUE))
	status <- attr(res, "status", TRUE)
	if (length(status) > 0 && status > 0) {
	rlang::abort(c("Running Pandoc failed with following error", res))
	}

[cderv]

Though this is what I see....

> xfun::write_utf8("dummy", "test.md")
> pandoc_convert("test.md", from = "markdown", to = "word")
Error in `pandoc_run()` at pandoc/R/pandoc-convert.R:64:2:
! Running Pandoc failed with following error
• Unknown output format word
Run `rlang::last_trace()` to see where the error occurred.

In which context do you see the above ?

In reprex I am missing a line message it seems...

xfun::write_utf8("dummy", "test.md")
pandoc::pandoc_convert("test.md", from = "markdown", to = "word")
#> Error in `pandoc_run()`:
#> ! Running Pandoc failed with following error
#> Backtrace:
#>     ▆
#>  1. └─pandoc::pandoc_convert("test.md", from = "markdown", to = "word")
#>  2.   └─pandoc::pandoc_run(args, version = version)
#>  3.     └─rlang::abort(...)

^{Created on 2023-09-22 with reprex v2.0.2}

[cderv]

Ok - I can reproduce on Linux. So probably the same on Mac.

[cderv]

This is about message capture for Pandoc output. It is not working the same on Windows and Linux.

On windows

> xfun::write_utf8("dummy", "test.md")
> system2(fs::path_expand(pandoc::pandoc_bin()), c("--to", "word", "test.md"), stdout = TRUE)
[1] "Unknown output format word"
attr(,"status")
[1] 22
Message d'avis :
Dans system2(fs::path_expand(pandoc::pandoc_bin()), c("--to", "word",  :
  l'exécution de la commande '"C:/Users/chris/AppData/Local/r-pandoc/r-pandoc/3.1.8/pandoc.exe" --to word test.md' renvoie un statut 22

On Linux

❯ system2(fs::path_expand(pandoc::pandoc_bin()), c("--to", "word", "test.md"), stdout = TRUE)
Unknown output format word
character(0)
attr(,"status")
[1] 22
Warning message:
In system2(fs::path_expand(pandoc::pandoc_bin()), c("--to", "word",  :
  running command ''/home/cderv/.local/share/r-pandoc/2.16.2/pandoc' --to word test.md' had status 22

I need stderr = TRUE here obviously, but the difference in behavior between OS for R is quite disturbing... 🤔

[cderv]

Thanks ! this is fixed in dev version now.

[hadley]

Thank you!