In evaluate, return the correct value when the result is falsy #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change evaluate(..., return_by_value=True) would incorrectly return None for any falsy result. Also cleanup the return_by_value=False case, by removing an unnecessary check for remote_object.deep_serialized_value. See the linked issue for the rationale. Fixes cdpdriver#201.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
stephanlensky
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this change
evaluate(..., return_by_value=True)wouldincorrectly return
Nonefor any falsy result.Also cleanup the
return_by_value=Falsecase, by removing anunnecessary check for
remote_object.deep_serialized_value. See thelinked issue for the rationale.
Fixes #201.
Pre-merge Checklist
./scripts/format.shand./scripts/lint.shscripts. My code is properly formatted and has no linting errors.uv run pytestand ensured all tests pass.[Unreleased]section.