feat: add inspect tab to compose #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [@octokit/graphql](https://github.com/octokit/graphql.js) from 5.0.6 to 6.0.0. - [Release notes](https://github.com/octokit/graphql.js/releases) - [Commits](octokit/graphql.js@v5.0.6...v6.0.0) --- updated-dependencies: - dependency-name: "@octokit/graphql" dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
We now require node 18+ and yarn install fails on 16. Signed-off-by: Tim deBoer <git@tdeboer.ca>
The Images list is too wide by default and causes unnecessary scroll bars. This fix makes it consistent with the other lists. Signed-off-by: Tim deBoer <git@tdeboer.ca>
Signed-off-by: Ondrej Dockal <odockal@redhat.com>
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Bumps [tar-fs](https://github.com/mafintosh/tar-fs) from 2.1.1 to 3.0.2. - [Commits](mafintosh/tar-fs@v2.1.1...v3.0.2) --- updated-dependencies: - dependency-name: tar-fs dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Fixing PR containers#2863 has exposed issues with all of the 'child form pages': - build/pull/run image - play kube - deploy pod - create pod from container Prior to the change these pages were all reliant on scrolling to exist somewhere external and the entire page would scroll. Although it often looked poor in some cases you could always get to the content. Now that we have fixed page headers and no automatic scrolling, these pages need to declare which div to autoscroll on. While fixing this I found that two screens had prior scrolling/display issues, and controls would appear 'outside' of the background panel or partially hidden offscreen. Although they're not directly related it made sense to fix them here so that I could confirm the correct scrolling behaviour: DeployPodToKube - The h-1/3 was causing the height calculation to be wrong and the Deploy button was often hanging off the bottom of the panel. Use a fixed height for the editor instead. PodCreateFromContainers - The minimum width would force unnecessary scrollbars when the window was narrow, and float-right left the Close and Create Pod buttons hanging off the bottom of the panel. Signed-off-by: Tim deBoer <git@tdeboer.ca>
Moves overflow-auto 'up' to the NavPage so that all child content automatically scrolls as necessary. Moved top of search bar padding to bottom of title - this helps child pages without search so that there is a little padding under the title (when scrolling the content doesn't look like it hits the title). Most child content divs require 'min-w-full and h-fit' so that the form stays full width but only as large vertically as necessary, made this consistent. Signed-off-by: Tim deBoer <git@tdeboer.ca>
Even when the quick pick is fixed to show which items are pre-selected (issue containers#2754 item 2) it is not really clear to the user why one row is highlighted. This adds the text " (current)" to the current Kube context to make this obvious. Signed-off-by: Tim deBoer <git@tdeboer.ca>
Jeff's suggestion is better. Signed-off-by: Tim deBoer <git@tdeboer.ca>
Bumps [@rollup/plugin-commonjs](https://github.com/rollup/plugins/tree/HEAD/packages/commonjs) from 25.0.1 to 25.0.2. - [Changelog](https://github.com/rollup/plugins/blob/master/packages/commonjs/CHANGELOG.md) - [Commits](https://github.com/rollup/plugins/commits/commonjs-v25.0.2/packages/commonjs) --- updated-dependencies: - dependency-name: "@rollup/plugin-commonjs" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 5.59.11 to 5.60.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.60.0/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…nt (containers#2930) Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Bumps [eslint-plugin-svelte](https://github.com/sveltejs/eslint-plugin-svelte) from 2.30.0 to 2.31.0. - [Release notes](https://github.com/sveltejs/eslint-plugin-svelte/releases) - [Changelog](https://github.com/sveltejs/eslint-plugin-svelte/blob/main/CHANGELOG.md) - [Commits](sveltejs/eslint-plugin-svelte@v2.30.0...v2.31.0) --- updated-dependencies: - dependency-name: eslint-plugin-svelte dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 5.59.11 to 5.60.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.60.0/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
it'll reconnect dockerode to the socket entries containers#2858 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
It is easier to test (then add a test file) Signed-off-by: Florent Benoit <fbenoit@redhat.com>
will allow to grab logs Signed-off-by: Florent Benoit <fbenoit@redhat.com>
* chore: add ping container engine method Signed-off-by: Florent Benoit <fbenoit@redhat.com>
…containers#2940) * chore: add listContainers helper method from a connection info object Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Bumps [svelte](https://github.com/sveltejs/svelte) from 3.59.1 to 3.59.2. - [Release notes](https://github.com/sveltejs/svelte/releases) - [Changelog](https://github.com/sveltejs/svelte/blob/v3.59.2/CHANGELOG.md) - [Commits](sveltejs/svelte@v3.59.1...v3.59.2) --- updated-dependencies: - dependency-name: svelte dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@octokit/graphql](https://github.com/octokit/graphql.js) from 6.0.0 to 6.0.1. - [Release notes](https://github.com/octokit/graphql.js/releases) - [Commits](octokit/graphql.js@v6.0.0...v6.0.1) --- updated-dependencies: - dependency-name: "@octokit/graphql" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [tar-fs](https://github.com/mafintosh/tar-fs) from 3.0.2 to 3.0.3. - [Commits](mafintosh/tar-fs@v3.0.2...v3.0.3) --- updated-dependencies: - dependency-name: tar-fs dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [octokit](https://github.com/octokit/octokit.js) from 2.0.22 to 2.1.0. - [Release notes](https://github.com/octokit/octokit.js/releases) - [Commits](octokit/octokit.js@v2.0.22...v2.1.0) --- updated-dependencies: - dependency-name: octokit dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
… (containers#2959) Signed-off-by: lstocchi <lstocchi@redhat.com>
Bumps [svelte-check](https://github.com/sveltejs/language-tools) from 3.4.3 to 3.4.4. - [Release notes](https://github.com/sveltejs/language-tools/releases) - [Commits](sveltejs/language-tools@svelte-check-3.4.3...svelte-check-3.4.4) --- updated-dependencies: - dependency-name: svelte-check dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [electron](https://github.com/electron/electron) from 25.1.1 to 25.2.0. - [Release notes](https://github.com/electron/electron/releases) - [Changelog](https://github.com/electron/electron/blob/main/docs/breaking-changes.md) - [Commits](electron/electron@v25.1.1...v25.2.0) --- updated-dependencies: - dependency-name: electron dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
* docs: updated Building an image procedure Signed-off-by: Fabrice Flore-Thébault <ffloreth@redhat.com> * docs: implemented suggestions Signed-off-by: Fabrice Flore-Thébault <ffloreth@redhat.com> * Update website/docs/getting-started/building-an-image.md Co-authored-by: Florent BENOIT <fbenoit@redhat.com> Signed-off-by: Fabrice Flore-Thébault <ffloreth@redhat.com> --------- Signed-off-by: Fabrice Flore-Thébault <ffloreth@redhat.com> Co-authored-by: Florent BENOIT <fbenoit@redhat.com>
* fix: add check before writing to terminal Signed-off-by: lstocchi <lstocchi@redhat.com> * fix: enhance tests Signed-off-by: lstocchi <lstocchi@redhat.com> --------- Signed-off-by: lstocchi <lstocchi@redhat.com>
…tainers#3257) * fix: wait until remote side has fully initialized the extensions fixes containers#3196 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
* feat: enable to retrieve lifecycleContext from api Signed-off-by: lstocchi <lstocchi@redhat.com> * chore: rename function and add comment Signed-off-by: lstocchi <lstocchi@redhat.com> --------- Signed-off-by: lstocchi <lstocchi@redhat.com>
### What does this PR do? ### Screenshot/screencast of this PR <!-- Please include a screenshot or a screencast explaining what is doing this PR --> ### What issues does this PR fix or reference? <!-- Please include any related issue from Podman Desktop repository (or from another issue tracker). --> ### How to test this PR? <!-- Please explain steps to reproduce --> Signed-off-by: Charlie Drage <charlie@charliedrage.com>
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
* feat: add support for views contributions Signed-off-by: lstocchi <lstocchi@redhat.com> * fix: remove null type to when clause Signed-off-by: lstocchi <lstocchi@redhat.com> --------- Signed-off-by: lstocchi <lstocchi@redhat.com>
…ntainers#3276) Signed-off-by: lstocchi <lstocchi@redhat.com>
Signed-off-by: lstocchi <lstocchi@redhat.com>
Bumps [eslint-plugin-svelte](https://github.com/sveltejs/eslint-plugin-svelte) from 2.32.2 to 2.32.3. - [Release notes](https://github.com/sveltejs/eslint-plugin-svelte/releases) - [Changelog](https://github.com/sveltejs/eslint-plugin-svelte/blob/main/CHANGELOG.md) - [Commits](sveltejs/eslint-plugin-svelte@v2.32.2...v2.32.3) --- updated-dependencies: - dependency-name: eslint-plugin-svelte dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [electron](https://github.com/electron/electron) from 25.3.0 to 25.3.1. - [Release notes](https://github.com/electron/electron/releases) - [Changelog](https://github.com/electron/electron/blob/main/docs/breaking-changes.md) - [Commits](electron/electron@v25.3.0...v25.3.1) --- updated-dependencies: - dependency-name: electron dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [svelte](https://github.com/sveltejs/svelte/tree/HEAD/packages/svelte) from 4.0.5 to 4.1.0. - [Release notes](https://github.com/sveltejs/svelte/releases) - [Changelog](https://github.com/sveltejs/svelte/blob/master/packages/svelte/CHANGELOG.md) - [Commits](https://github.com/sveltejs/svelte/commits/svelte@4.1.0/packages/svelte) --- updated-dependencies: - dependency-name: svelte dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…tainers#3287) Signed-off-by: lstocchi <lstocchi@redhat.com>
use undefined instead Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
…extensions fixes containers#2829 fixes containers#2828 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
* feat: add initial support for contexts Signed-off-by: lstocchi <lstocchi@redhat.com> * fix: fix tests Signed-off-by: lstocchi <lstocchi@redhat.com> * fix: add vscode copyright and link Signed-off-by: lstocchi <lstocchi@redhat.com> * fix: clean based on review Signed-off-by: lstocchi <lstocchi@redhat.com> * fix: remove null type/value and add counter for id generation Signed-off-by: lstocchi <lstocchi@redhat.com> * fix: fix format Signed-off-by: lstocchi <lstocchi@redhat.com> * fix: fix test Signed-off-by: lstocchi <lstocchi@redhat.com> * fix: remove null types Signed-off-by: lstocchi <lstocchi@redhat.com> --------- Signed-off-by: lstocchi <lstocchi@redhat.com>
Bumps [svelte](https://github.com/sveltejs/svelte/tree/HEAD/packages/svelte) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/sveltejs/svelte/releases) - [Changelog](https://github.com/sveltejs/svelte/blob/master/packages/svelte/CHANGELOG.md) - [Commits](https://github.com/sveltejs/svelte/commits/svelte@4.1.1/packages/svelte) --- updated-dependencies: - dependency-name: svelte dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [eslint-plugin-svelte](https://github.com/sveltejs/eslint-plugin-svelte) from 2.32.3 to 2.32.4. - [Release notes](https://github.com/sveltejs/eslint-plugin-svelte/releases) - [Changelog](https://github.com/sveltejs/eslint-plugin-svelte/blob/main/CHANGELOG.md) - [Commits](sveltejs/eslint-plugin-svelte@v2.32.3...v2.32.4) --- updated-dependencies: - dependency-name: eslint-plugin-svelte dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…tion (containers#3291) * feat(tests): introduce globalSetup, extract shared configuration, page object model and podman desktop runner fixes containers#3288, containers#3290, containers#3302 Signed-off-by: Ondrej Dockal <odockal@redhat.com>
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 4.4.4 to 4.4.6. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v4.4.6/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
* fix: fix loader not centered horizontally Signed-off-by: Tim deBoer <git@tdeboer.ca> Co-authored-by: Florent BENOIT <fbenoit@redhat.com>
…rs#3131) * feat: allow extensions to customize icons (containers#1899) Signed-off-by: lstocchi <lstocchi@redhat.com> * fix: keep storage to server and move evaluation to renderer Signed-off-by: lstocchi <lstocchi@redhat.com> * fix: clean and add tests Signed-off-by: lstocchi <lstocchi@redhat.com> * fix: rename file and fix function signature Signed-off-by: lstocchi <lstocchi@redhat.com> * fix: move contextKeyValue type Signed-off-by: lstocchi <lstocchi@redhat.com> * fix: clean after messed rebase Signed-off-by: lstocchi <lstocchi@redhat.com> * fix: replace icon and refactor Signed-off-by: lstocchi <lstocchi@redhat.com> * chore: replace icon with one with margin Signed-off-by: lstocchi <lstocchi@redhat.com> --------- Signed-off-by: lstocchi <lstocchi@redhat.com>
* feat: extend context and contextkey service Signed-off-by: lstocchi <lstocchi@redhat.com> * feat: add support for all rules Signed-off-by: lstocchi <lstocchi@redhat.com> * fix: fix sonar issues Signed-off-by: lstocchi <lstocchi@redhat.com> --------- Signed-off-by: lstocchi <lstocchi@redhat.com>
fixes containers#3305 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
* feat: add ability to view compose logs ### What does this PR do? When clicking on the group of containers, you can now view the logs of the entire group of compsoe containers. ### Screenshot/screencast of this PR <!-- Please include a screenshot or a screencast explaining what is doing this PR --> ### What issues does this PR fix or reference? <!-- Please include any related issue from Podman Desktop repository (or from another issue tracker). --> Closes containers#3103 ### How to test this PR? 1. Deploy a docker-compose example (https://raw.githubusercontent.com/kubernetes/kompose/main/examples/docker-compose.yaml) 2. Go to the container view in PD 3. Press on the container group 4. View the logs <!-- Please explain steps to reproduce --> Signed-off-by: Charlie Drage <charlie@charliedrage.com> * fix: update based on review Signed-off-by: Charlie Drage <charlie@charliedrage.com> --------- Signed-off-by: Charlie Drage <charlie@charliedrage.com>
…s#3312) * fix: do not use server side code directly in renderer part * chore: fix context key methods fixes containers#3310 Signed-off-by: Florent Benoit <fbenoit@redhat.com> Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Bumps [postcss](https://github.com/postcss/postcss) from 8.4.26 to 8.4.27. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@8.4.26...8.4.27) --- updated-dependencies: - dependency-name: postcss dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
### What does this PR do? * Adds the inspect tab to Compose which is an array of "container inspect" from docker / podman. * Inspect is JSON array of containers, see docker/compose#4155 for inspiration (they don't actually have a `compose inspect` command..) * Adds tests ### Screenshot/screencast of this PR <!-- Please include a screenshot or a screencast explaining what is doing this PR --> ### What issues does this PR fix or reference? <!-- Please include any related issue from Podman Desktop repository (or from another issue tracker). --> Closes containers#3192 ### How to test this PR? 1. Deploy a compose example 2. Click on the compose group 3. Select the inspect tab <!-- Please explain steps to reproduce --> Signed-off-by: Charlie Drage <charlie@charliedrage.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add inspect tab to compose
What does this PR do?
inspect" from docker / podman.
docker-compose inspect docker/compose#4155 for inspiration (they
don't actually have a
compose inspectcommand..)Screenshot/screencast of this PR
What issues does this PR fix or reference?
Closes containers#3192
How to test this PR?
Signed-off-by: Charlie Drage charlie@charliedrage.com