-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the name of the branch in all notify repos to 'main' #1289
Comments
The main problem is with our deploy pipeline https://github.com/cds-snc/notification-pr-bot/blob/aa7a3a15129dd3dd48111c4f82ab7b50f643d9de/index.js#L17-L43 and Kubernetes https://github.com/cds-snc/notification-manifests |
For the PR bot, what happens if there is an entry in there for a branch that doesn't exist? Do we know if the bot will just ignore it? If it does, we could add 'main' alongside 'master' in the list and then remove 'master' post deploy. If it doesn't support it .... do we control the code, could I make it supported? For Kubernetes, I don't have knowledge of kubernetes so I don't know how hard it would be to migrate. Do you deploy on every push? Could we prepare the kubernetes change in a branch that gets committed soon after the changes to other repos? |
@jzbahrai can you please have a look at this one? Thanks |
I have the feeling this issue could be closed ( |
Yes, the mainline branch for all our active projects are now in |
Notification repos left to change to
main
:The text was updated successfully, but these errors were encountered: