Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the name of the branch in all notify repos to 'main' #1289

Closed
8 tasks
dj2 opened this issue May 5, 2021 · 6 comments
Closed
8 tasks

Change the name of the branch in all notify repos to 'main' #1289

dj2 opened this issue May 5, 2021 · 6 comments

Comments

@dj2
Copy link

dj2 commented May 5, 2021

Notification repos left to change to main:

  • Notification-admin
  • Notification-api
  • Notification-utils
  • notification-document-download-api
  • notification-document-download-frontend
  • notification-pr-bot
  • notification-scheduler
  • notifications-bulk-send
@AntoineAugusti
Copy link
Contributor

@dj2
Copy link
Author

dj2 commented May 6, 2021

For the PR bot, what happens if there is an entry in there for a branch that doesn't exist? Do we know if the bot will just ignore it? If it does, we could add 'main' alongside 'master' in the list and then remove 'master' post deploy.

If it doesn't support it .... do we control the code, could I make it supported?

For Kubernetes, I don't have knowledge of kubernetes so I don't know how hard it would be to migrate. Do you deploy on every push? Could we prepare the kubernetes change in a branch that gets committed soon after the changes to other repos?

@yaelberger-commits
Copy link

@jzbahrai can you please have a look at this one? Thanks

@jzbahrai jzbahrai changed the title Transition to main for primary branch? Change the name of the branch in all notify repos to 'main' Jan 13, 2022
@HEYGUL
Copy link

HEYGUL commented Apr 8, 2022

I have the feeling this issue could be closed (main branch seems now alive instead of master).

@jimleroyer
Copy link
Member

Yes, the mainline branch for all our active projects are now in main for quite some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants