Skip to content
This repository has been archived by the owner on Oct 20, 2020. It is now read-only.

Recommend removing references to osg namespaced versions of typed arrays #13

Closed
DamonOehlman opened this issue Nov 10, 2012 · 1 comment

Comments

@DamonOehlman
Copy link
Contributor

I noticed these definitions and would probably recommend removing them and also any references to them within the code. Going with direct versions would definitely be recommended IMO.

Happy to make the changes if you are happy to go ahead with the suggestion.

@cedricpinson
Copy link
Owner

well in fact it was done to be able to reference all buffer allocated in osgjs, So it's not used anymore and not mandatory to use them but it's convenient when you want to customise the behaviour of the constructor when you instance a buffer.
Does it makes sense for you ?

Cedric Pinson
Provide OpenGL, WebGL services
+33 659 598 614 -
http://cedricpinson.com (http://plopbyte.com/) - http://osgjs.org (http://osgjs.org/) - http://sketchfab.com (http://showwebgl.com/)

On Saturday, November 10, 2012 at 07:38 , Damon Oehlman wrote:

I noticed these definitions (https://github.com/cedricpinson/osgjs/blob/develop/js/osg/osg.js#L207) and would probably recommend removing them and also any references to them within the code. Going with direct versions would definitely be recommended IMO.
Happy to make the changes if you are happy to go ahead with the suggestion.


Reply to this email directly or view it on GitHub (#13).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants