Fix 622 by setting correct WCF attributes to allow multiple calls #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sylvain-hamel Much cleaner solution! Thanks! |
|
Just reading the MSDN article on
I've put comments inline. |
| @@ -6,7 +6,8 @@ | |||
|
|
|||
| namespace CefSharp.Internals | |||
| { | |||
| [ServiceBehavior(InstanceContextMode = InstanceContextMode.PerSession)] | |||
| [ServiceBehavior(InstanceContextMode = InstanceContextMode.PerSession, ConcurrencyMode = ConcurrencyMode.Multiple)] | |||
| [CallbackBehavior(ConcurrencyMode = ConcurrencyMode.Multiple)] | |||
There was a problem hiding this comment.
From what I can tell [CallbackBehavior] is only required on the IRenderProcess class
amaitland
added a commit
to amaitland/CefSharp
that referenced
this pull request
Nov 21, 2014
|
@sylvain-hamel What do you think of amaitland@06e2a1a? Quick test and everything looks ok, I think that's the minimum required code change. |
This was referenced Nov 21, 2014
Closed
|
@amaitland your are right. you can remove the extra lines when your will merge. |
|
Closing in favor of #630 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@amaitland I think this is a better fix. What do you think?