Add minimal version of GenTrap (Arb8) shape #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethrj
added
enhancement
sethrj
changed the title
sethrj
requested changes
Mar 30, 2024
There was a problem hiding this comment.
Thanks @mrguilima ! There's still a bit of work to do but I this is solid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the GenTrap shape [orange]
Tracing unit tests to be implemented in another MR.
This is a simplified version of the GenTrap (or ROOT's Arb8) shape, which still does not support twisted side faces.
Also, for the case of triangular z-faces, it seems to work properly for well behaved cases (e.g. triangular prism), while failing for harder ones, like when the two z-face triangles are not directly aligned (e.g. mirror-reflected triangles).
Lastly, the ROOT docs suggest that a tetrahedron (1 + 3 vertices) should work, but this is not yet supported.
Still, the current implementation works for a lot of the intended cases, as far as the side-faces are planar.