Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tox version limit #8464

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Remove tox version limit #8464

merged 1 commit into from
Aug 30, 2023

Conversation

Nusnus
Copy link
Member

@Nusnus Nusnus commented Aug 30, 2023

This reverts #8443.
tox v4.11 now works normally.
We're potentially now dependent on 4.11> but I'll leave it without restrictions for now.

@Nusnus Nusnus added this to the 5.3.x milestone Aug 30, 2023
@Nusnus Nusnus self-assigned this Aug 30, 2023
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (dabccf0) 87.42% compared to head (07c4961) 87.42%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8464   +/-   ##
=======================================
  Coverage   87.42%   87.42%           
=======================================
  Files         148      148           
  Lines       18488    18488           
  Branches     3155     3155           
=======================================
  Hits        16164    16164           
  Misses       2034     2034           
  Partials      290      290           
Flag Coverage Δ
unittests 87.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

requirements/pkgutils.txt Outdated Show resolved Hide resolved
@Nusnus Nusnus changed the title Limit tox to <4.9 in pkgutils.txt - missed that in #8443 Remove tox limit from #8443 Aug 30, 2023
@Nusnus Nusnus changed the title Remove tox limit from #8443 Remove tox version limit Aug 30, 2023
@Nusnus
Copy link
Member Author

Nusnus commented Aug 30, 2023

Code cov is failing again.. I'll let it breathe a bit and try again.

@Nusnus Nusnus marked this pull request as ready for review August 30, 2023 15:54
@Nusnus Nusnus merged commit af1d7a1 into celery:main Aug 30, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants