Fix for #359 MySQL-OperationalError #370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the database connection dies (database server crash), the database scheduler of djcelery doesn't close the broken connection for its scheduler update calls. Every 5 seconds an OperationalError: (2006, 'MySQL server has gone away') occurs. This patches checks the database connection when a DATABASE_ERROR occurs and closes the connection when necessary. The database scheduler reconnects automatically on the next try.
|
@trunneml hi, thanks for the patch, could you check the other PR's related to this issue? they are referenced here. I am going to asses which approach is better. |
|
@auvipy hi, it's been along time since I worked with django-celery. But in my opinion it is best to try to close the db connection in case of an problem. Django will reconnect next time. Don't catching the exception could stop the beat which could be a problem. My patch is based on the way how django handles such a case, so I prefer my patch. ;-) |
|
Is there any reason this patch was not merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the database connection dies (database server crash), the database scheduler of djcelery doesn't close the broken connection for its scheduler update calls. Every 5 seconds an OperationalError: (2006, 'MySQL server has gone away') occurs.
This patches checks the database connection when a DATABASE_ERROR occurs and closes the connection when necessary. The database scheduler reconnects automatically on the next try.