Skip to content

Resolved some warnings in tests. #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2016
Merged

Resolved some warnings in tests. #473

merged 1 commit into from
Sep 25, 2016

Conversation

vytisb
Copy link
Contributor

@vytisb vytisb commented Sep 25, 2016

Also, added -Wall to tox config so that all warnings would be reported.

Resolved warnings:

RemovedInDjango110Warning: You haven't defined a TEMPLATES setting. You must do so before upgrading to Django 1.10. Otherwise Django will be unable to load templates.
RemovedInDjango20Warning: Importing from django.core.urlresolvers is deprecated in favor of django.urls.
RemovedInDjango20Warning: Old-style middleware using settings.MIDDLEWARE_CLASSES is deprecated. Update your middleware and use settings.MIDDLEWARE instead.
DeprecationWarning: assertDictContainsSubset is deprecated
ResourceWarning: unclosed file <_io.TextIOWrapper name='/home/vytis/src/django-celery/tests/someapp/tasks.py' mode='U' encoding='utf-8'>

@auvipy
Copy link
Member

auvipy commented Sep 25, 2016

looks good and thanks for the PR. would be great to have the changelog/release notes.

@vytisb
Copy link
Contributor Author

vytisb commented Sep 25, 2016

Added a changelog entry.

@auvipy auvipy merged commit 1612037 into celery:master Sep 25, 2016
@vytisb vytisb deleted the warnings branch September 25, 2016 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants