Rename async keyword to asynchronous
#839
Conversation
* Fixes celery#742 * Resolves "DeprecationWarning: 'async' and 'await' will become reserved keywords in Python 3.7"
Codecov Report
@@ Coverage Diff @@
## master #839 +/- ##
=========================================
- Coverage 87.44% 86.15% -1.3%
=========================================
Files 61 63 +2
Lines 6261 6486 +225
Branches 725 767 +42
=========================================
+ Hits 5475 5588 +113
- Misses 709 818 +109
- Partials 77 80 +3
Continue to review full report at Codecov.
|
Changelog
Outdated
| @@ -866,7 +866,7 @@ Deprecations and removals | |||
| :release-date: 2014-09-04 03:00 P.M UTC | |||
| :release-by: Ask Solem | |||
|
|
|||
| - kombu.async: Min. delay between waiting for timer was always increased to | |||
| - kombu.asynchronous: Min. delay between waiting for timer was always increased to | |||
There was a problem hiding this comment.
There's no need to edit old release notes. Please remove these from the PR.
Changelog
Outdated
| @@ -937,7 +937,7 @@ Deprecations and removals | |||
| :release-date: 2014-06-02 06:00 P.M UTC | |||
| :release-by: Ask Solem | |||
|
|
|||
| - A typo introduced in 3.0.17 caused kombu.async.hub to crash (Issue #360). | |||
| - A typo introduced in 3.0.17 caused kombu.asynchronous.hub to crash (Issue #360). | |||
There was a problem hiding this comment.
There's no need to edit old release notes. Please remove these from the PR.
Changelog
Outdated
| @@ -1488,7 +1488,7 @@ Deprecations and removals | |||
| same security implications as pickle, but Kombu uses the | |||
| :func:`yaml.safe_load` function which is not known to be affected. | |||
|
|
|||
| - kombu.async: Experimental event loop implementation. | |||
| - kombu.asynchronous: Experimental event loop implementation. | |||
There was a problem hiding this comment.
There's no need to edit old release notes. Please remove these from the PR.
|
Thank you very much for your contribution. |
Latest Kombu renamed async to asynchronous celery/kombu#839 breaking Celery, which has a PR to fix this celery/celery#4679 but the changes haven't been released yet celery/celery#4387 so we use this in the interim.
This fixes an issue with use of reserved keywords as identifiers (`async`). See celery/kombu#839
This fixes an issue with use of reserved keywords as identifiers (`async`). See celery/kombu#839
* Rename `async` keyword to `asynchronous` * Fixes celery#742 * Resolves "DeprecationWarning: 'async' and 'await' will become reserved keywords in Python 3.7" * Address PR feedback * Update appveyor config * Rename docs and tests
|
@thedrow Could this be applied to kombu v3 as well? It will be nice to support python37 for celery 3.1.25. |
|
lol no. that version is long been abandoned and we are focusing on celery 5 and 4.x versions stability |
There will be other problems with 3.7 support on the v3 branch. |
keywords in Python 3.7"