Skip to content

Invalid row root namespace node when verifying proofs #193

@rach-id

Description

@rach-id

In the DAVerifier, when verifying share proofs, we're creating an invalid row root namespace node:
https://github.com/celestiaorg/quantum-gravity-bridge/blob/ddcb943075c30dfff42380739c00d605488b4dde/src/lib/verifier/DAVerifier.sol#L110-L111

The min/max namespaces are not correct.

This was not caught by the tests because the DAVerifier tests only use a single transaction in the block. Thus, the min/max namespaces are equal.

To fix this, we could just directly use the row root namespace node from the proof, instead of creating it manually there. This would also optimise a bit of gas.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions