-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(node): unified node constructor #104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgmt
@Bidon15, @liamsi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls make NewFull
and NewLight
private, otherwise lgtm
…ors receiving type as a param
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Context
In #86 we moved
Open/Init/IsInit
functions over the unified pattern where they receive Node Type as param. Now, it makes total sense to introduce aNew
Node constructor to would instantiate a Node for a given type. For now, old constructors(NewFull/NewLight) are preserved, same as withDefaultLight(Full)Config
but we can make them private and/or remove them if we find a reason for that in future