Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated linters #1150

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

rootulp
Copy link
Contributor

@rootulp rootulp commented Sep 22, 2022

Closes #1149

The unused linter is already enabled:

- unused

@codecov-commenter
Copy link

Codecov Report

Merging #1150 (71a02b3) into main (a036bc6) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1150      +/-   ##
==========================================
- Coverage   56.78%   56.75%   -0.04%     
==========================================
  Files         141      141              
  Lines        9381     9381              
==========================================
- Hits         5327     5324       -3     
- Misses       3507     3510       +3     
  Partials      547      547              
Impacted Files Coverage Δ
ipld/get_shares.go 90.00% <0.00%> (-10.00%) ⬇️
ipld/get_namespaced_shares.go 90.51% <0.00%> (+2.18%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it seems like new warnings after #1067. Thanks for such contributions ❤️

@rootulp rootulp merged commit 1d338f5 into celestiaorg:main Sep 22, 2022
@rootulp rootulp deleted the rp/golangci-warnings branch September 22, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

golangci-lint warnings
4 participants