bugfix(nodebuilder/fraud): remove fraud.Subscriber from module #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaynay
requested changes
Sep 26, 2022
vgonkivs
force-pushed
the
remove_fraud_subscriber_from_module
branch
from
4c102c3
to
1f6769d
Compare
Wondertan
approved these changes
Sep 26, 2022
distractedm1nd
approved these changes
Sep 27, 2022
renaynay
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not nessesary to invoke
new(fraud.Subscriber)in the Module creation because this instances of fraud.Subscriber is not used anywhere. According to our logic it should be passed to OnProof and OnProof is invoked from Lifecycle that receives fraud.Service as an input parameter.