refactor(rpc): move sanity check logic from rpc handlers to implementations. #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HoytRen
requested review from
renaynay,
Wondertan,
vgonkivs and
distractedm1nd
as code owners
Wondertan
previously approved these changes
Oct 10, 2022
There was a problem hiding this comment.
LGTM, but defer the proper review to @renaynay and @distractedm1nd
Codecov Report
@@ Coverage Diff @@
## main #1213 +/- ##
==========================================
+ Coverage 55.76% 55.92% +0.16%
==========================================
Files 161 161
Lines 9650 9645 -5
==========================================
+ Hits 5381 5394 +13
+ Misses 3740 3720 -20
- Partials 529 531 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
distractedm1nd
previously approved these changes
Oct 12, 2022
distractedm1nd
changed the title
distractedm1nd
changed the title
|
Rebased twice, and it still failed... |
|
Yeah, we have some flakiness in tests |
|
happy to see it passed :) |
HoytRen
force-pushed
the
#998
branch
2 times, most recently
from
a9d48b1
to
52ae07a
Compare
Take Wondertan's suggestion. Co-authored-by: Hlib Kanunnikov <hlibwondertan@gmail.com>
distractedm1nd
approved these changes
Oct 19, 2022
renaynay
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see only 1 implementation. Tell me if here are more.
Close #998