Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(share/ipld): Use consts for node type determination #1244

Merged
merged 3 commits into from
Oct 19, 2022
Merged

refactor(share/ipld): Use consts for node type determination #1244

merged 3 commits into from
Oct 19, 2022

Conversation

renaynay
Copy link
Member

Self-explanatory

@renaynay renaynay added area:shares Shares and samples area:ipld IPLD plugin kind:improvement labels Oct 19, 2022
@renaynay renaynay self-assigned this Oct 19, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2022 •
edited
Loading

Codecov Report

Merging #1244 (d56d63d) into main (d239616) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1244      +/-   ##
==========================================
+ Coverage   55.86%   55.89%   +0.02%     
==========================================
  Files         160      160              
  Lines        9725     9719       -6     
==========================================
- Hits         5433     5432       -1     
+ Misses       3756     3751       -5     
  Partials      536      536
Impacted Files Coverage Δ
share/ipld/namespace_hasher.go 100.00% <100.00%> (ø)
fraud/bad_encoding.go 63.00% <0.00%> (-3.00%) ⬇️
state/core_access.go 12.28% <0.00%> (-0.84%) ⬇️
service/rpc/state.go 0.00% <0.00%> (ø)
header/core/listener.go 58.49% <0.00%> (+5.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Bidon15
Bidon15 approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@Bidon15 Bidon15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@renaynay renaynay merged commit fdd8b30 into celestiaorg:main Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wondertan Wondertan Wondertan approved these changes

@MSevey MSevey MSevey approved these changes

@walldiss walldiss walldiss approved these changes

@Bidon15 Bidon15 Bidon15 approved these changes

@vgonkivs vgonkivs Awaiting requested review from vgonkivs vgonkivs is a code owner

@distractedm1nd distractedm1nd Awaiting requested review from distractedm1nd

Assignees

@renaynay renaynay

Labels
area:ipld IPLD plugin area:shares Shares and samples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@renaynay @codecov-commenter @Bidon15 @walldiss @MSevey @Wondertan