Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(share): incorrect TestGetSharesByNamespace test #1342

Merged
merged 1 commit into from
Nov 11, 2022
Merged

fix(share): incorrect TestGetSharesByNamespace test #1342

merged 1 commit into from
Nov 11, 2022

Conversation

walldiss
Copy link
Member

Resolves #1333

@walldiss walldiss self-assigned this Nov 10, 2022
@walldiss walldiss added kind:fix Attached to bug-fixing PRs area:shares Shares and samples labels Nov 10, 2022
@walldiss walldiss changed the title fix incorrect TestGetSharesByNamespace test share: fix incorrect TestGetSharesByNamespace test Nov 10, 2022
@walldiss walldiss changed the title share: fix incorrect TestGetSharesByNamespace test fix(share): incorrect TestGetSharesByNamespace test Nov 10, 2022
Wondertan
Wondertan approved these changes Nov 10, 2022
View reviewed changes
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Catch!

distractedm1nd
distractedm1nd approved these changes Nov 10, 2022
View reviewed changes
Copy link
Collaborator

@distractedm1nd distractedm1nd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent ser

renaynay
renaynay approved these changes Nov 11, 2022
View reviewed changes
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@walldiss walldiss merged commit 90bd741 into celestiaorg:main Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renaynay renaynay renaynay approved these changes

@Wondertan Wondertan Wondertan approved these changes

@distractedm1nd distractedm1nd distractedm1nd approved these changes

@vgonkivs vgonkivs Awaiting requested review from vgonkivs vgonkivs is a code owner

Assignees

@walldiss walldiss

Labels
area:shares Shares and samples kind:fix Attached to bug-fixing PRs
Projects
No open projects
Celestia Node
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

share: TestGetSharesByNamespace is incorrect and false positive.
4 participants
@walldiss @distractedm1nd @Wondertan @renaynay