node: add cache for blockstore #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgonkivs
requested review from
liamsi,
mattdf,
renaynay and
Wondertan
as code owners
liamsi
reviewed
Oct 14, 2021
There was a problem hiding this comment.
Thanks a lot for this! I want @Wondertan to review this as soon as he is back.
Looks good to me but I don't have any insights into potential ramifications.
Wondertan
previously approved these changes
Oct 15, 2021
liamsi
approved these changes
Oct 15, 2021
There was a problem hiding this comment.
Thanks a lot for your contribution @vgonkivs 👏🏼 and thanks for the review @Wondertan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cached blockstore was used instead of common.
CacheOpts contains 3 params:
Closes #108