Add version command #159
Merged
Add version command #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orlandorode97
requested review from
liamsi,
mattdf,
renaynay and
Wondertan
as code owners
renaynay
previously approved these changes
Oct 29, 2021
There was a problem hiding this comment.
Thank you so much @OrlandoRomo ! This is awesome. The only question I have is whether we should keep the version command definition in its own file (version.go) or have a general utils.go file that stores all util/admin-like cmds. WDYT @Wondertan ?
|
@renaynay, file per command is readable and a good practice IMO, so I would keep things the way they are in this PR. |
Wondertan
previously approved these changes
Oct 29, 2021
orlandorode97
dismissed stale reviews from Wondertan and renaynay
via
5a9cebb
Wondertan
reviewed
Oct 30, 2021
Wondertan
approved these changes
Oct 30, 2021
adlerjohn
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal for this PR is to add the
versionsubcommand ofcelestiacommand to get more information about the build binary. The new subcommand closes #155.version command in action