feat(share)!: add functional options to share pkg #1798
Merged
+235
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrandz
requested review from
renaynay,
Wondertan,
vgonkivs and
distractedm1nd
as code owners
derrandz
added
enhancement
derrandz
changed the title
derrandz
force-pushed
the
feat/share/functional-options
branch
from
6359309
to
41c8612
Compare
Codecov Report
@@ Coverage Diff @@
## main #1798 +/- ##
==========================================
- Coverage 57.44% 57.44% -0.01%
==========================================
Files 242 243 +1
Lines 16211 16391 +180
==========================================
+ Hits 9313 9415 +102
- Misses 5954 6019 +65
- Partials 944 957 +13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
walldiss
requested changes
Mar 13, 2023
|
@derrandz some conversations seems to be resolved by you, but there is no response, nor any changes applied. Are they resolved by mistake? |
|
I resolved locally but ended up facing the import cycle issue and not pushing @walldiss so they are implemented but not pushed yet. Will unresolve til I push. |
derrandz
force-pushed
the
feat/share/functional-options
branch
from
a8ba5a3
to
9000f51
Compare
renaynay
requested changes
Mar 17, 2023
Wondertan
previously approved these changes
May 3, 2023
distractedm1nd
previously approved these changes
May 4, 2023
renaynay
requested changes
May 4, 2023
walldiss
reviewed
May 4, 2023
derrandz
force-pushed
the
feat/share/functional-options
branch
from
89096ab
to
c8f713c
Compare
derrandz
force-pushed
the
feat/share/functional-options
branch
from
c8f713c
to
2045029
Compare
Wondertan
previously approved these changes
May 4, 2023
Wondertan
reviewed
May 4, 2023
renaynay
reviewed
May 5, 2023
Wondertan
reviewed
May 5, 2023
Wondertan
approved these changes
May 5, 2023
renaynay
approved these changes
May 8, 2023
vgonkivs
approved these changes
May 8, 2023
walldiss
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces functional options to the share package and deprecates usage of default values directly in code, in favor of using parameterized values.
Breaking
This PR breaks the configuration. The on-disk configuration becomes (note that
Share.Availabilityis only available for light nodes):Checklist