refactor(share/p2p/shrex): use default timeout for shrex-eds client #2114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walldiss
requested review from
renaynay,
Wondertan,
vgonkivs and
distractedm1nd
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2114 +/- ##
==========================================
- Coverage 55.80% 55.53% -0.28%
==========================================
Files 209 209
Lines 13289 13338 +49
==========================================
- Hits 7416 7407 -9
- Misses 5131 5185 +54
- Partials 742 746 +4
... and 8 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Wondertan
reviewed
Apr 20, 2023
renaynay
reviewed
Apr 21, 2023
Wondertan
previously approved these changes
Apr 21, 2023
renaynay
previously approved these changes
Apr 26, 2023
Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
Wondertan
approved these changes
Apr 26, 2023
renaynay
approved these changes
Apr 26, 2023
Wondertan
pushed a commit
that referenced
this pull request
Apr 27, 2023
…2114) ## Overview Use default timeout for shrex-eds client if no deadline specified by provided context. --------- Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Use default timeout for shrex-eds client if no deadline specified by provided context.