Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nodebuilder): timeouts, errors and logs #2125

Merged
merged 6 commits into from
May 2, 2023

Conversation

Wondertan
Copy link
Member

@Wondertan Wondertan commented Apr 24, 2023

Was originally for debugging purposes but actually solved the issue. The bootstrapper with a corrupted DAGstore state was not able to start quickly enough.

Ideally, we should make this value configurable(#2126)

@Wondertan Wondertan added the kind:fix Attached to bug-fixing PRs label Apr 24, 2023
@Wondertan
Copy link
Member Author

So this actually fixed bootstrapper, as it didn't have enough time to Start.

@Wondertan Wondertan marked this pull request as ready for review April 24, 2023 17:22
@Wondertan Wondertan self-assigned this Apr 24, 2023
@Wondertan Wondertan added the area:node Node label Apr 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2023

Codecov Report

Merging #2125 (e3009b7) into main (7f95c72) will decrease coverage by 0.03%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main    #2125      +/-   ##
==========================================
- Coverage   55.48%   55.46%   -0.03%     
==========================================
  Files         209      209              
  Lines       13324    13329       +5     
==========================================
  Hits         7393     7393              
- Misses       5188     5192       +4     
- Partials      743      744       +1     
Impacted Files Coverage Δ
nodebuilder/node.go 57.35% <40.00%> (-2.97%) ⬇️

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

renaynay
renaynay previously approved these changes Apr 25, 2023
@Wondertan
Copy link
Member Author

Squeezing in one more change related to fx logging. We now can see fx event logs by simply enabling Debug level for fx
Also, I've done some error message prettification

@Wondertan Wondertan changed the title fix(nodebuilder): increase start timeout chore(nodebuilder): timeouts, errors and logs Apr 25, 2023
nodebuilder/node.go Show resolved Hide resolved
nodebuilder/node.go Show resolved Hide resolved
@Wondertan Wondertan enabled auto-merge (squash) April 27, 2023 16:00
@Wondertan Wondertan merged commit 5c0b128 into main May 2, 2023
@Wondertan Wondertan deleted the hlib/node/increase-start-timeout branch May 2, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:node Node kind:fix Attached to bug-fixing PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants