Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cmd): allow setting log level for start comamnd #217

Merged
merged 1 commit into from
Nov 19, 2021
Merged

Conversation

Wondertan
Copy link
Member

Closes #210.

Btw, you can also set logging level through ENV

Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

cmd/start.go Show resolved Hide resolved
Copy link
Contributor

@jbowen93 jbowen93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wondertan Wondertan merged commit 677e30d into main Nov 19, 2021
@Wondertan Wondertan deleted the hlib/log-flag branch November 19, 2021 11:05
@Wondertan Wondertan restored the hlib/log-flag branch January 7, 2022 14:40
@Wondertan Wondertan deleted the hlib/log-flag branch January 7, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logging level should be configurable via flag or config file on startup
4 participants