Fix Makefile docstrings and phony targets. #2194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adlerjohn
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd and
walldiss
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2194 +/- ##
==========================================
- Coverage 55.82% 55.80% -0.03%
==========================================
Files 216 216
Lines 14060 14091 +31
==========================================
+ Hits 7849 7863 +14
- Misses 5422 5441 +19
+ Partials 789 787 -2
|
Wondertan
approved these changes
May 13, 2023
vgonkivs
approved these changes
May 14, 2023
5 tasks
adlerjohn
added a commit
that referenced
this pull request
May 17, 2023
## Overview Missed one in #2194. ## Checklist - [ ] New and updated code has appropriate documentation - [ ] New and updated code has new and/or updated testing - [ ] Required CI checks are passing - [ ] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords
vgonkivs
pushed a commit
to vgonkivs/celestia-node
that referenced
this pull request
May 22, 2023
## Overview Some docstrings and phony targets were outdated/incomplete. Fix. ## Checklist - [ ] New and updated code has appropriate documentation - [ ] New and updated code has new and/or updated testing - [ ] Required CI checks are passing - [ ] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords
vgonkivs
pushed a commit
to vgonkivs/celestia-node
that referenced
this pull request
May 22, 2023
## Overview Missed one in celestiaorg#2194. ## Checklist - [ ] New and updated code has appropriate documentation - [ ] New and updated code has new and/or updated testing - [ ] Required CI checks are passing - [ ] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Some docstrings and phony targets were outdated/incomplete. Fix.
Checklist