Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(shrex/server): add warn logs to shrex server #2197

Merged
merged 3 commits into from
May 15, 2023
Merged

refactor(shrex/server): add warn logs to shrex server #2197

merged 3 commits into from
May 15, 2023

Conversation

walldiss
Copy link
Member

Overview

Add some warn logs for shrex server for to improve edge cases visibility.

@walldiss walldiss added area:shares Shares and samples area:p2p kind:refactor Attached to refactoring PRs labels May 15, 2023
@walldiss walldiss self-assigned this May 15, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #2197 (2f96b28) into main (9ecf08f) will decrease coverage by 0.09%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main    #2197      +/-   ##
==========================================
- Coverage   55.89%   55.81%   -0.09%     
==========================================
  Files         216      216              
  Lines       14091    14094       +3     
==========================================
- Hits         7876     7866      -10     
- Misses       5425     5441      +16     
+ Partials      790      787       -3
Impacted Files Coverage Δ
header/header.go 61.40% <ø> (ø)
share/p2p/shrexnd/server.go 67.34% <66.66%> (+0.45%) ⬆️
share/availability/discovery/discovery.go 78.29% <100.00%> (+0.85%) ⬆️
share/p2p/shrexeds/server.go 65.85% <100.00%> (+0.27%) ⬆️

... and 4 files with indirect coverage changes

Wondertan
Wondertan previously approved these changes May 15, 2023
View reviewed changes
share/availability/discovery/discovery.go Outdated Show resolved Hide resolved
@walldiss walldiss requested a review from Wondertan May 15, 2023 12:18
renaynay
renaynay reviewed May 15, 2023
View reviewed changes
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls add some more details to debug lgos

share/p2p/shrexeds/server.go Show resolved Hide resolved
share/p2p/shrexnd/server.go Show resolved Hide resolved
share/p2p/shrexnd/server.go Show resolved Hide resolved
share/p2p/shrexnd/server.go Show resolved Hide resolved
@walldiss walldiss enabled auto-merge (squash) May 15, 2023 13:01
@walldiss walldiss requested a review from renaynay May 15, 2023 13:07
@walldiss walldiss merged commit 2fa72c7 into celestiaorg:main May 15, 2023
renaynay
renaynay reviewed May 15, 2023
View reviewed changes
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot about logger with

vgonkivs pushed a commit to vgonkivs/celestia-node that referenced this pull request May 22, 2023
@walldiss @vgonkivs
refactor(shrex/server): add warn logs to shrex server (celestiaorg#2197)
4e1ef8b 
## Overview
Add some warn logs for shrex server for to improve edge cases
visibility.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renaynay renaynay renaynay left review comments

@Wondertan Wondertan Wondertan approved these changes

@distractedm1nd distractedm1nd distractedm1nd approved these changes

@vgonkivs vgonkivs Awaiting requested review from vgonkivs vgonkivs is a code owner

Assignees

@walldiss walldiss

Labels
area:p2p area:shares Shares and samples kind:refactor Attached to refactoring PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@walldiss @codecov-commenter @distractedm1nd @Wondertan @renaynay