chore(das): improve logging #2209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wondertan
requested review from
renaynay,
vgonkivs,
distractedm1nd and
walldiss
as code owners
Wondertan
added
area:shares
Wondertan
commented
May 15, 2023
Codecov Report
@@ Coverage Diff @@
## main #2209 +/- ##
==========================================
- Coverage 55.84% 55.84% -0.01%
==========================================
Files 216 216
Lines 14106 14115 +9
==========================================
+ Hits 7877 7882 +5
- Misses 5442 5447 +5
+ Partials 787 786 -1
|
distractedm1nd
previously approved these changes
May 16, 2023
walldiss
reviewed
May 16, 2023
distractedm1nd
previously approved these changes
May 16, 2023
walldiss
approved these changes
May 16, 2023
distractedm1nd
approved these changes
May 16, 2023
vgonkivs
pushed a commit
to vgonkivs/celestia-node
that referenced
this pull request
May 22, 2023
Every new head now produces fewer logs + makes the more informative
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every new head now produces fewer logs + makes the more informative
Looks like below now
