Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(share/discovery): add backoff metrics #2212

Merged
merged 3 commits into from
May 17, 2023
Merged

feat(share/discovery): add backoff metrics #2212

merged 3 commits into from
May 17, 2023

Conversation

walldiss
Copy link
Member

Overview

Add metrics to discovery.

@walldiss walldiss added area:shares Shares and samples kind:feat Attached to feature PRs labels May 16, 2023
@walldiss walldiss requested a review from renaynay as a code owner May 16, 2023 09:33
@walldiss walldiss self-assigned this May 16, 2023
@walldiss walldiss changed the title feat(discovery/metrics): add backoff metrics feat(share/discovery): add backoff metrics May 16, 2023
@walldiss walldiss force-pushed the discovery_backoff_size_metric branch from 82ed421 to c7ca216 Compare May 16, 2023 09:35
Wondertan
Wondertan reviewed May 16, 2023
View reviewed changes
Copy link
Member

@Wondertan Wondertan left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

one little typo

share/availability/discovery/backoff.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #2212 (c7ca216) into main (e06aa7f) will decrease coverage by 0.18%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #2212      +/-   ##
==========================================
- Coverage   55.95%   55.77%   -0.18%     
==========================================
  Files         216      216              
  Lines       14103    14122      +19     
==========================================
- Hits         7891     7877      -14     
- Misses       5425     5458      +33     
  Partials      787      787
Impacted Files Coverage Δ
nodebuilder/header/header.go 11.11% <0.00%> (-1.39%) ⬇️
nodebuilder/header/service.go 13.11% <0.00%> (-0.45%) ⬇️
share/availability/discovery/discovery.go 75.00% <16.66%> (-2.03%) ⬇️
share/availability/discovery/metrics.go 47.05% <57.14%> (+0.63%) ⬆️
share/p2p/shrexnd/server.go 67.34% <66.66%> (+0.45%) ⬆️
share/availability/discovery/backoff.go 86.79% <100.00%> (+1.07%) ⬆️
share/p2p/shrexeds/server.go 65.85% <100.00%> (+0.27%) ⬆️

... and 5 files with indirect coverage changes

@walldiss walldiss enabled auto-merge (squash) May 17, 2023 09:52
@walldiss walldiss merged commit bd70494 into celestiaorg:main May 17, 2023
11 of 12 checks passed
vgonkivs pushed a commit to vgonkivs/celestia-node that referenced this pull request May 22, 2023
@walldiss @vgonkivs
feat(share/discovery): add backoff metrics (celestiaorg#2212)
60b2d7f 
## Overview

Add metrics to discovery.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@distractedm1nd distractedm1nd distractedm1nd approved these changes

@Wondertan Wondertan Wondertan approved these changes

@renaynay renaynay Awaiting requested review from renaynay renaynay is a code owner

@vgonkivs vgonkivs Awaiting requested review from vgonkivs vgonkivs is a code owner

Assignees

@walldiss walldiss

Labels
area:shares Shares and samples kind:feat Attached to feature PRs
Projects
Celestia Node
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@walldiss @codecov-commenter @distractedm1nd @Wondertan