Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement(test/swamp): set core IP and Port to nodes #2226

Merged

Conversation

vgonkivs
Copy link
Member

@vgonkivs vgonkivs commented May 18, 2023

Overview

configure test nodes to be able to access the core node and set keyring from an already funded account in order to submit transactions.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@vgonkivs vgonkivs added swamp Related to Integration tests kind:misc Attached to miscellaneous PRs e2e e2e testing related labels May 18, 2023
@vgonkivs vgonkivs self-assigned this May 18, 2023
@vgonkivs vgonkivs requested a review from Bidon15 May 18, 2023 10:00
@codecov-commenter
Copy link

Codecov Report

Merging #2226 (a784354) into main (ecf7956) will decrease coverage by 0.13%.
The diff coverage is 96.29%.

@@            Coverage Diff             @@
##             main    #2226      +/-   ##
==========================================
- Coverage   55.89%   55.77%   -0.13%     
==========================================
  Files         216      216              
  Lines       14115    14142      +27     
==========================================
- Hits         7889     7887       -2     
- Misses       5438     5464      +26     
- Partials      788      791       +3     
Impacted Files Coverage Δ
header/header.go 58.82% <75.00%> (-2.58%) ⬇️
das/subscriber.go 88.23% <100.00%> (ø)
das/worker.go 95.86% <100.00%> (+0.21%) ⬆️

... and 8 files with indirect coverage changes

Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

nodebuilder/tests/swamp/swamp.go Show resolved Hide resolved
@vgonkivs vgonkivs enabled auto-merge (squash) May 19, 2023 12:34
@vgonkivs vgonkivs merged commit be937f2 into celestiaorg:main May 19, 2023
vgonkivs added a commit to vgonkivs/celestia-node that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e e2e testing related kind:misc Attached to miscellaneous PRs swamp Related to Integration tests
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants