Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service/header: Verify hash matches header retrieved in RequestByHash() #224

Merged
merged 3 commits into from
Nov 23, 2021
Merged

service/header: Verify hash matches header retrieved in RequestByHash() #224

merged 3 commits into from
Nov 23, 2021

Conversation

renaynay
Copy link
Member

@renaynay renaynay commented Nov 19, 2021 •
edited
Loading

Resolves #219

TODO

  • tests
  • implement same check for p2p ex

@renaynay renaynay added the area:header Extended header label Nov 19, 2021
liamsi
liamsi previously approved these changes Nov 19, 2021
View reviewed changes
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct. Will the TODOs in the opening comment be resolved here or in follow up PRs?

liamsi
liamsi previously approved these changes Nov 19, 2021
View reviewed changes
Copy link
Member

@liamsi liamsi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

adlerjohn
adlerjohn previously approved these changes Nov 20, 2021
View reviewed changes
Copy link
Member

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahhh I'm approoooving!

@renaynay renaynay dismissed stale reviews from adlerjohn and liamsi via e441137 November 22, 2021 10:53
Wondertan
Wondertan reviewed Nov 22, 2021
View reviewed changes
service/header/core_exchange.go Show resolved Hide resolved
service/header/exchange.go Outdated Show resolved Hide resolved
liamsi
liamsi previously approved these changes Nov 22, 2021
View reviewed changes
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still approoooving anyways!

Wondertan
Wondertan previously approved these changes Nov 22, 2021
View reviewed changes
@renaynay renaynay dismissed stale reviews from Wondertan and liamsi via 79bac66 November 22, 2021 16:37
liamsi
liamsi previously approved these changes Nov 22, 2021
View reviewed changes
@Wondertan Wondertan merged commit a3bb430 into celestiaorg:main Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wondertan Wondertan Wondertan approved these changes

@adlerjohn adlerjohn adlerjohn approved these changes

@liamsi liamsi liamsi left review comments

@mattdf mattdf Awaiting requested review from mattdf

Assignees
No one assigned
Labels
area:header Extended header
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

service/header: Exchange should verify that requested hash matches the header
4 participants
@renaynay @adlerjohn @liamsi @Wondertan