fix(share/discovery): timeout FindPeers operation #2263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wondertan
added
area:shares
Wondertan
requested review from
renaynay,
vgonkivs,
distractedm1nd and
walldiss
as code owners
|
@walldiss, pls test to reconfirm the fix works |
walldiss
previously approved these changes
May 26, 2023
renaynay
reviewed
May 29, 2023
|
I have run node with this PR and never seen stuck discovery since then |
Codecov Report
@@ Coverage Diff @@
## main #2263 +/- ##
=======================================
Coverage 50.44% 50.44%
=======================================
Files 150 150
Lines 9318 9294 -24
=======================================
- Hits 4700 4688 -12
+ Misses 4217 4204 -13
- Partials 401 402 +1
|
walldiss
previously approved these changes
May 29, 2023
vgonkivs
reviewed
May 30, 2023
Wondertan
changed the title
|
We discussed in sync that we don't want to merge the fix, we are not sure it is fixing anything, so we removed the buffer. We can continue testing to see if the discovery still gets stuck |
renaynay
approved these changes
May 30, 2023
vgonkivs
approved these changes
May 30, 2023
Wondertan
added a commit
that referenced
this pull request
May 30, 2023
…peration (#2263) Closes #2258 Two cases were possible: * Sometimes, the discovery is not triggered, and memorizing triggers might help * It's an unconfirmed theory, and we are still determining if it fixes anything yet. * We considered a case with @walldiss, but it should not happen. * FindPeers can get stuck sometimes for an indefinite time and so forth stopping the whole discovery. We should stop and restart it.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 21, 2023
Closes #2263 Co-authored-by: Hlib Kanunnikov <hlibwondertan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2258
FindPeers can get stuck sometimes for an indefinite time and so forth, stopping the whole discovery. We should stop and restart it.