feat(node): implement node.AuthVerify and node.AuthNew #2370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distractedm1nd
requested review from
renaynay,
Wondertan,
vgonkivs and
walldiss
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2370 +/- ##
==========================================
- Coverage 50.80% 50.54% -0.26%
==========================================
Files 155 155
Lines 9766 9826 +60
==========================================
+ Hits 4962 4967 +5
- Misses 4369 4426 +57
+ Partials 435 433 -2
|
renaynay
previously approved these changes
Jun 15, 2023
Implements node.AuthVerify and node.AuthNew. Removes the jwt.Signer from the Node struct and replaces it with the nodebuilder.Node module, along with the other services.
distractedm1nd
force-pushed
the
authnewverify
branch
from
2de376d
to
c46be0c
Compare
Wondertan
approved these changes
Jun 15, 2023
walldiss
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements node.AuthVerify and node.AuthNew.
Removes the jwt.Signer from the Node struct and replaces it with the nodebuilder.Node module, along with the other services.
Includes a minor version bump to the API.